chore(NODE-4641): remove wire version checks for unsupported servers#3416
Merged
baileympearson merged 3 commits intomongodb:mainfrom Sep 28, 2022
Merged
chore(NODE-4641): remove wire version checks for unsupported servers#3416baileympearson merged 3 commits intomongodb:mainfrom
baileympearson merged 3 commits intomongodb:mainfrom
Conversation
baileympearson
changed the title
baileympearson
added
the
Primary Review
baileympearson
suggested changes
Sep 16, 2022
Contributor
baileympearson
left a comment
baileympearson
left a comment
There was a problem hiding this comment.
Can we also update the wire version checks in update and delete related to hint?
Contributor
|
Hey @LinusU - are you able to make the changes I requested? If not, I'm happy to take over the PR from here if that's okay with you. |
baileympearson
force-pushed
the
wire-version-cleanup
branch
from
03df187 to
cd4acfe
Compare
nbbeeken
approved these changes
Sep 28, 2022
Contributor
Author
|
sorry for not getting back to you earlier, and thank you so much for landing this PR! ❤️ |
ZLY201
pushed a commit
to ZLY201/node-mongodb-native
that referenced
this pull request
Nov 5, 2022
…ongodb#3416) Co-authored-by: Bailey Pearson <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
As a follow up to #3409, this removes all wire version checks which check for a version that is no longer supported by this driver.
What is changing?
Code that wasn't used is being removed.
Is there new documentation needed for these changes?
No
What is the motivation for this change?
My motivation behind this was to clean up the code, and remove unnecessary checks.
Double check the following
npm run check:lintscript<type>(NODE-xxxx)<!>: <description>I think so, there is no issue number for this but saw other commits that omitted this